Skip to content

Fix IE9 reordering HTML attributes in the key. #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2015

Conversation

maxpeterson
Copy link
Contributor

It seems that ie9 reorders some attributes this causes the key not to match.

For example <span title="The title" class="test">Test</span> will be rendered as <span class="test" title="The title">Test</span> by ie9. The result is that the key does not match the value when looked up by the directive.

The fix very similar to #131

It seems that ie9 reorders some attributes this causes the key not to
match.
@maxpeterson
Copy link
Contributor Author

@rubenv should I have created a test for this? Do you have any way of automating IE tests.

@rubenv
Copy link
Owner

rubenv commented Feb 3, 2015

I would love to have automated IE tests, but we sadly don't have them yet.

Any help there would be greatly appreciated.

For now I test all changes through our main project that heavily uses angular-gettext. For that one we have a full CI setup (with tons of browsers). Unfortunately I can't use it for open-source purposes (who would pay the bills? :-)).

@rubenv
Copy link
Owner

rubenv commented Feb 3, 2015

As for this patch, I'll test it, if it works it's good to go in.

@rubenv rubenv merged commit 05b2b87 into rubenv:master Feb 3, 2015
@rubenv
Copy link
Owner

rubenv commented Feb 3, 2015

Merged! Thanks a lot!

@rubenv
Copy link
Owner

rubenv commented Feb 3, 2015

Tagged as "v2.0.2"

@maxpeterson
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants