-
Notifications
You must be signed in to change notification settings - Fork 476
Deeply nested objects #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A bit of progress on my side. My nested objects have the correct type/format which is encouraging. |
I've also added a nested object with Array[Array[String]] which is currently restitute as Array[String] |
This reverts commit e5ba63b.
Here's an example of a CHANGELOG.md entry: * [#752](https://github.com/ruby-grape/grape-swagger/pull/752): Deeply nested objects - [@braktar](https://github.com/braktar). Generated by 🚫 danger |
So, maybe a bit of explanation. MoveParams was following the formData structure in order to build the definition, losing a lot of information useful for the body format. So instead of it, the definition is now build with the body format (without losing information) and is then modified only if the formData is required. I've currently removed the vehicle test as I don't see what is the correct way to read an array[array[string]] as well as the output expected for it. |
thanks @braktar … good job |
* Depply nested objects * Simple hash syntax edit * Nested objects are not necessary arrays * fix points test * Fix test services * Doesn't require to delete hash or array properties * Edit nested logic * Add vehicle test * Change parameter level is endpoint job * Array body shouldn't lost array type * no more parser role * array of array to array of string * move format data * fix formdata return * Moved params_parser role spec * Move endpoint spec * Revert "Add vehicle test" This reverts commit e5ba63b. * remove redundant interpolation
Related to: #751