Skip to content

Correctly set BerIdentifiedString values to UTF-8 #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2015
Merged

Correctly set BerIdentifiedString values to UTF-8 #212

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a83fb32
Server strings are always UTF-8
cmdrclueless Aug 25, 2015
04125c7
Correctly encode to UTF-8 when possible
cmdrclueless Aug 25, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/net/ber.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,9 +296,11 @@ def to_arr
class Net::BER::BerIdentifiedString < String
attr_accessor :ber_identifier
def initialize args
super args
# LDAP uses UTF-8 encoded strings
self.encode('UTF-8') if self.respond_to?(:encoding) rescue self
super begin
args.respond_to?(:encode) ? args.encode('UTF-8') : args
rescue
args
end
end
end

Expand Down