Skip to content

Conversation

pvdb
Copy link

@pvdb pvdb commented Aug 6, 2019

... and fix the following Ruby warning in the process:

lib/net/ldap/instrumentation.rb:15: warning: shadowing outer local variable - payload

Doesn't change anything functionally, and the tests still pass! 😃

Copy link
Member

@HarlemSquirrel HarlemSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@HarlemSquirrel HarlemSquirrel merged commit c725cd1 into ruby-ldap:master Jul 2, 2020
@pvdb
Copy link
Author

pvdb commented Jul 5, 2020

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants