Skip to content

Conversation

tompng
Copy link
Member

@tompng tompng commented Sep 3, 2025

Modifying bigdecimal/math.rb might break JRuby. One example is #415.

JRuby uses its own native implementation, but uses the same ruby-implemented BigMath implementation.
Adds a minimum ci to ensure BigMath methods works in JRuby.

# Commented out two assertion because it's failing in jruby 10.0.2.0 (passes in jruby 9.4.9.0)
assert_in_delta(2 ** 2.5, BigDecimal(2) ** 2.5)
assert_in_delta(2 ** 2.5, BigDecimal(2).power(2.5, N))
# <5.656854249492381> -/+ <0.001> was expected to include
#   <0.4e1>.

@tompng tompng merged commit b458f94 into ruby:master Sep 3, 2025
81 checks passed
@tompng tompng deleted the jruby-ci branch September 3, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant