Implement to_d in Numeric and with the same number of arguments everywhere #423
+10
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsateler
changed the title
…where This allows user code to be more generic, not having to care about the specific class. Preserve the BigDecimal override to allow returning the same object.
fsateler
force-pushed
the
feature/numeric-to-d
branch
from
f66b7dc to
7dbbe1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows user code to be more generic, not having to care
about the specific class.
Preserve the BigDecimal override to allow returning the same object.
--
This is a PoC PR. I don't know if this is desired. But my intuition would be that all Numeric types should be convertible to BigDecimal, with the same interface. What do you think?
Builds on top of #421 to avoid conflicts