Skip to content

🐛 Fix empty SASL-IR to send "=" #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2023
Merged

🐛 Fix empty SASL-IR to send "=" #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/net/imap.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1236,7 +1236,8 @@ def authenticate(mechanism, *creds, sasl_ir: true, **props, &callback)
cmdargs = ["AUTHENTICATE", mechanism]
if sasl_ir && capable?("SASL-IR") && auth_capable?(mechanism) &&
SASL.initial_response?(authenticator)
cmdargs << [authenticator.process(nil)].pack("m0")
response = authenticator.process(nil)
cmdargs << (response.empty? ? "=" : [response].pack("m0"))
end
result = send_command(*cmdargs) do |resp|
if resp.instance_of?(ContinuationRequest)
Expand Down
18 changes: 18 additions & 0 deletions test/net/imap/test_imap.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -847,6 +847,24 @@ def test_id
end
end

test("#authenticate sends '=' as the initial reponse " \
"when the initial response is an empty string") do
with_fake_server(
preauth: false, cleartext_auth: true,
sasl_ir: true, sasl_mechanisms: %i[EXTERNAL],
) do |server, imap|
server.on "AUTHENTICATE" do |cmd|
server.state.authenticate(server.config.user)
cmd.done_ok
end
imap.authenticate("EXTERNAL")
cmd = server.commands.pop
assert_equal "AUTHENTICATE", cmd.name
assert_equal %w[EXTERNAL =], cmd.args
assert_empty server.commands rescue pp server.commands.pop
end
end

test("#authenticate never sends an initial response " \
"when the server doesn't explicitly support the mechanism") do
with_fake_server(
Expand Down