ssl: use SSL_CTX_set_dh_auto() by default #924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think the failure with openssl-master with the fips provider is relevant, but I haven't been able to reproduce it locally. |
This was referenced Aug 1, 2025
I executed the current latest master branch dfbbac6 with the latest OpenSSL master branch openssl/openssl@b20da23. I can see the failure below. https://github.com/junaruga/ruby-openssl/actions/runs/16680199093/job/47216748820 |
|
I opened the issue ticket #926 for the FIPS test failures. |
rhenium
force-pushed
the
ky/ssl-dh-auto
branch
2 times, most recently
from
127b28e to
c4185e6
Compare
Update the test case to explicitly load both the "default" and the "legacy" providers. Currently, the "default" provider as a side effect by the OpenSSL::PKey::DH.new call in lib/openssl/ssl.rb. It will be cleaned up in a following patch.
Check for the function we actually use. Both SSL_set0_tmp_dh_pkey() and SSL_CTX_set0_tmp_dh_pkey() were added in OpenSSL 3.0.
Rely on OpenSSL's builtin DH parameters for TLS 1.2 and earlier instead of providing a default SSLContext#tmp_dh_callback proc. SSL_CTX_set_dh_auto() has been available since OpenSSL 1.1.0. The parameters can still be overridden by specifying SSLContext#tmp_dh_callback or #tmp_dh, as confirmed by existing tests. SSLContext#tmp_dh_callback depends on a deprecated OpenSSL feature. We also prefer not to hard-code parameters, which is a maintenance burden. This change also improves Ractor compatibility by removing the unshareable proc.
tmp_dh_callback no longer has a default value. It also no longer has to share code with tmp_ecdh_callback, which has been removed in v3.0.0.
rhenium
force-pushed
the
ky/ssl-dh-auto
branch
from
c4185e6 to
a6f83fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable automatic DH parameters for TLS 1.2 or earlier when neither
SSLSocket#tmp_dhnorSSLSocket#tmp_dh_callbackis set. This is supported since OpenSSL 1.1.0.This allows us to remove the default
tmp_dh_callbackproc defined inlib/openssl/ssl.rb, which uses hard-coded parameters and is not Ractor-shareable.Also, a few cleanups in related code:
provider: load "default" provider in test_openssl_legacy_provider
Explicitly load both the "default" and "legacy" providers in the test case.
The "legacy" provider is intended to be used with the "default" provider. The "default" provider is typically loaded automatically, but that only happens when no other provider has been loaded yet.
ssl: fix extconf.rb check for SSL_CTX_set0_tmp_dh_pkey()
Check for the function we actually use. Both SSL_set0_tmp_dh_pkey() and SSL_CTX_set0_tmp_dh_pkey() were added in OpenSSL 3.0.
ssl: refactor tmp_dh_callback handling
tmp_dh_callback no longer has a default value. It also no longer has to share code with tmp_ecdh_callback, which was removed in v3.0.0.