Skip to content

Fix segmentation fault of Pathname#split when File.split returns non array value [Bug #17755] #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2021
Merged

Fix segmentation fault of Pathname#split when File.split returns non array value [Bug #17755] #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e29b49e
Add test for raising TypeError instead of segfault
kachick Mar 27, 2021
1db7479
Fix segfault of Pathname#split
kachick Mar 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/pathname/pathname.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,7 +834,7 @@ path_split(VALUE self)
VALUE str = get_strpath(self);
VALUE ary, dirname, basename;
ary = rb_funcall(rb_cFile, id_split, 1, str);
ary = rb_check_array_type(ary);
Check_Type(ary, T_ARRAY);
dirname = rb_ary_entry(ary, 0);
basename = rb_ary_entry(ary, 1);
dirname = rb_class_new_instance(1, &dirname, rb_obj_class(self));
Expand Down
15 changes: 15 additions & 0 deletions test/pathname/test_pathname.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1067,6 +1067,21 @@ def test_expand_path

def test_split
assert_equal([Pathname("dirname"), Pathname("basename")], Pathname("dirname/basename").split)

assert_separately([], <<-'end;')
require 'pathname'

mod = Module.new do
def split(_arg)
end
end

File.singleton_class.prepend(mod)

assert_raise(TypeError) do
Pathname('/').split
end
end;
end

def test_blockdev?
Expand Down