Add a build:local_ruby task to simplify local testing flow
#1281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
reviewed
Jan 23, 2025
kou
reviewed
Jan 24, 2025
kou
reviewed
Jan 24, 2025
Rakefile
Outdated
| @@ -99,6 +99,11 @@ task :clean do | |||
| end | |||
| end | |||
|
|
|||
| desc "Build #{Bundler::GemHelper.gemspec.full_name} and move it to local ruby/ruby project's bundled gems folder" | |||
| task build_for_local_ruby: :build do | |||
There was a problem hiding this comment.
Can we use better task name something like local_ruby:build?
There was a problem hiding this comment.
Renamed it to build:local_ruby
A common way to test RDoc changes is to build `ruby/ruby`'s documentation with the latest RDoc changes. When RDoc was a default gem, we can sync it to `ruby/ruby` with its `tool/sync_default_gems.rb` script. Now that RDoc is a bundled gem, we need to use a different method to sync it to `ruby/ruby`. And so far building it and moving it to `ruby/ruby`'s bundled gems folder is the easiest way to do it.
st0012
force-pushed
the
add-build-for-local-ruby-task
branch
from
be43c22 to
c9c47e3
Compare
st0012
changed the title
build_for_local_ruby task to simplify local testing flowbuild:local_ruby task to simplify local testing flow
vinistock
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common way to test RDoc changes is to build
ruby/ruby's documentation with the latest RDoc changes. When RDoc was a default gem, we can sync it toruby/rubywith itstool/sync_default_gems.rbscript.Now that RDoc is a bundled gem, we need to use a different method to sync it to
ruby/ruby. And so far building it and moving it toruby/ruby's bundled gems folder is the easiest way to do it.