Fix image tag with external source #1348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `rdoc-image` contains an external source, such as `https://example.com/path/to/image.svg`, rendered `<img>` tag is broken. This fixes the bug. For example, I found the problem on the IRB website, where a Markdown image is present as a source. Rendered HTML on the website <https://ruby.github.io/irb/>: ```html <a href="https://badge.fury.io/rb/irb"><img src="https" alt="//badge.fury.io/rb/irb.svg:Gem Version"></a> ``` Markdown source: <https://github.com/ruby/irb/blob/6349b03f64f173a9d31bc9042430e1134f3e1689/doc/Index.md?plain=1#L3> ```markdown [](https://badge.fury.io/rb/irb) ``` Probably, this bug was introduced in the commit 894b2f1 (v6.13.0).
ybiquitous
commented
Apr 25, 2025
kou
reviewed
Apr 25, 2025
Co-authored-by: Sutou Kouhei <[email protected]>
](https://badge.fury.io/rb/irb){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
rdoc-imagecontains an external source, such ashttps://example.com/path/to/image.svg, the rendered<img>tag is broken. This PR fixes the bug.For example, I found the problem on the IRB website, where a Markdown image is present as a source.
Rendered HTML on the website https://ruby.github.io/irb/:
Screenshot:
Markdown source: https://github.com/ruby/irb/blob/6349b03f64f173a9d31bc9042430e1134f3e1689/doc/Index.md?plain=1#L3
Probably, this bug was introduced in the commit 894b2f1, i.e., https://github.com/ruby/rdoc/releases/tag/v6.13.0.