Skip to content

Removed strict dependency for json, it break to install ruby trunk(2.4) #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Jul 9, 2016

Ruby 2.4 can not build json-1.8.3. because it uses rb_cFixnum. this pull request allows to install json 2.0 later with rdoc.

@zzak zzak added this to the 5.0.0 milestone Jul 14, 2016
@zzak zzak mentioned this pull request Jul 14, 2016
3 tasks
@hsbt
Copy link
Member Author

hsbt commented Jul 14, 2016

json 2.0.0 later does not allow to install > Ruby 2.0.0 . We should remove json dependency and drop to support Ruby 1.8. I think.

@zzak
Copy link
Member

zzak commented Jul 14, 2016

@hsbt Got it, sounds good to me!

@hsbt
Copy link
Member Author

hsbt commented Aug 16, 2016

I update this for rdoc 5.0.0

@zzak
Copy link
Member

zzak commented Aug 16, 2016

@hsbt I think this needs a rebase since I merged #396

@hsbt hsbt force-pushed the relax-json-deps branch from 72f251b to 05d8284 Compare August 16, 2016 12:27
@hsbt
Copy link
Member Author

hsbt commented Aug 16, 2016

done.

@hsbt
Copy link
Member Author

hsbt commented Sep 6, 2016

I created another pull request. see #419

@hsbt hsbt closed this Sep 6, 2016
@hsbt hsbt deleted the relax-json-deps branch September 6, 2016 03:14
sanemat added a commit to sanemat/openid_connect that referenced this pull request Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants