Skip to content

Parse ruby 2.1 <visibility> def method definition #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2017
Merged

Parse ruby 2.1 <visibility> def method definition #435

merged 1 commit into from
Jan 25, 2017

Conversation

amatsuda
Copy link
Member

This patch adds an ability to parse ruby 2.1 style private def foo() method definition.

I suppose test/test_rdoc_context.rb is not the right place to put a test code for this, and also test/xref_data.rb may not be the right place to put the test data.
I'm willing to fix them if anyone can tell me where to put them.

fixes #355 #354

@hsbt
Copy link
Member

hsbt commented Jan 19, 2017

I felt this tests is correctly. but I didn't know right place to put them too.

@hsbt hsbt merged commit 7b660d0 into ruby:master Jan 25, 2017
@amatsuda amatsuda deleted the current_line_visibility branch January 27, 2017 07:15
@zzak
Copy link
Member

zzak commented Feb 24, 2017

👍 Thank you @amatsuda and @hsbt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<visibility> def hides following methods
3 participants