Run benchmark only when ENV['BENCHMARK'] == 'yes' #446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test suite of RDoc has a benchmark test. The benchmark test is run when
ENV['BENCHMARK']
is set, butRakefile
locksENV['BENCHMARK']
is'yes'
. Nobody can change whether to run benchmark. This won't serve the purpose.This Pull Request serves new behavior:
ENV['BENCHMARK']
is'yes'
Rakefile
setsENV['BENCHMARK']
as'yes'
only whenENV['BENCHMARK']
isn't setThe benchmark test runs with
rake
. The benchmark test doesn't run withBENCHMARK=no rake
.This is for avoidance of dependence on CI circumstances.