Skip to content

Add test for postfix if/unless/while/until #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2017

Conversation

aycabta
Copy link
Member

@aycabta aycabta commented Jul 9, 2017

The postfix form for if/unless/while/until is detected in IRB Ruby parser with special token types of TkIF_MOD/TkUNLESS_MOD/TkWHILE_MOD/TkUNTIL_MOD, but the detection is a new feature in parser.y after parsed with EXPR_LABEL bit, it's introduced after the birth of IRB.

So this is an important test to replace Ruby parser of IRB with Ripper.

The postfix form for if/unless/while/until is detected in IRB Ruby parser
with special token types of Tk{IF,UNLESS,WHILE,UNTIL}_MOD,
but the detection is a new feature in parser.y after parsed
with EXPR_LABEL bit,
it's introduced after the birth of IRB.
So this is an important test to replace Ruby parser of IRB with Ripper.
@zzak zzak merged commit f72c753 into ruby:master Jul 18, 2017
@aycabta aycabta deleted the add-test-for-postfix-if branch July 18, 2017 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants