Fix for symbol detection when nested method #491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When nested method as identifer detected, @lex_state is :EXPR_MID and it becomes :EXPR_END. However, in ":" token processing, TkSYMBEG is generated only when @lex_state is not :EXPR_END. So symbol for nested method becomes TkCOLON as distinct from TkSYMBEG. This commit fixes the behavior.
hsbt
requested changes
Aug 23, 2017
test/test_rdoc_ruby_lex.rb
Outdated
| @@ -789,28 +789,16 @@ def test_class_tokenize_symbol | |||
| assert_equal expected, tokens | |||
| end | |||
|
|
|||
| def test_class_tokenize_particular_kind_of_symbols | |||
There was a problem hiding this comment.
Is it a regression?
test_class_tokenize_particular_kind_of_symbols is still working test case.
…tection-when-nested-method
aycabta
force-pushed
the
fix-for-symbol-detection-when-nested-method
branch
from
f465519 to
a95c755
Compare
|
I fixed merging what is handled yesterday. Haste makes waste... |
…tection-when-nested-method
|
Thanks. Looks reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When nested method as identifer detected,
@lex_stateis:EXPR_MIDand it becomes:EXPR_END. However, in:token processing,TkSYMBEGis generated only when@lex_stateis not:EXPR_END. So symbol for nested method becomesTkCOLONas distinct fromTkSYMBEG.This Pull Request fixes the behavior.
Before:
The symbol,
:name, it consistsTkCOLONandTkIDENTIFIER.After(fixed):
The
:nameis a symbol.