Skip to content

Skip the same of outside of nested namespace #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 1, 2017
Merged

Skip the same of outside of nested namespace #523

merged 3 commits into from
Oct 1, 2017

Conversation

aycabta
Copy link
Member

@aycabta aycabta commented Sep 24, 2017

In the code below, the fullname of A::B is A::B, but it's treated as A::A::A::B now.

module A
  class A::B
  end
end

This Pull Request fixes it, and #516, #364, https://github.com/zzak/sdoc/issues/88.

@aycabta
Skip the same of outside of nested namespace
1d8674a 
In the code below, the fullname of A::B is A::B,
but it's treated as A::A::A::B now.

module A
  class A::B
  end
end

This commit fixes it.
@aycabta
Add test_parse_class_the_same_of_outside
96964f5
@aycabta
Add test_parse_constant_the_same_of_outside
cc55d91
This was referenced Sep 24, 2017
Closed
Closed
@aycabta aycabta merged commit f7fc033 into ruby:master Oct 1, 2017
@aycabta aycabta deleted the skip-the-same-of-outside-of-nested-namespace branch October 1, 2017 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aycabta