Skip to content

Support did_you_mean #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 10, 2017
Merged

Support did_you_mean #533

merged 3 commits into from
Oct 10, 2017

Conversation

aycabta
Copy link
Member

@aycabta aycabta commented Oct 2, 2017

Ruby 2.3 or later, did_you_mean gem is adopted as standard library. The did_you_mean gem can be used as a library via DidYouMean::SpellChecker at 1.0.3 or later, so checks that the class is defined and uses it. And then, this feature will become enabled if the gem 1.0.3 or later is installed.

This closes #45.

@aycabta aycabta changed the title Support did you mean Support did_you_mean Oct 2, 2017
DidYouMean::SpellChecker exists

Ruby 2.3 or later, did_you_mean gem is adopted as standard library. The
did_you_mean gem can be used as a library via DidYouMean::SpellChecker
at 1.0.3 or later, so checks that the class is defined and uses it. And
then, this feature will become enabled if the gem 1.0.3 or later is
installed.
@aycabta aycabta force-pushed the support-did_you_mean branch from 51e5fa4 to e492a67 Compare October 2, 2017 21:14
LoadError isn't caught by rescue without class because the default
exception class for rescue is StandardError.
@hsbt hsbt self-requested a review October 3, 2017 05:55
@yuki24
Copy link
Member

yuki24 commented Oct 3, 2017

looks good to me 👍🏻 thanks!

@hsbt
Copy link
Member

hsbt commented Oct 10, 2017

Great! It seems interesting and useful feature at RDoc 6.

@hsbt hsbt merged commit fc6d8ce into ruby:master Oct 10, 2017
matzbot pushed a commit to ruby/ruby that referenced this pull request Oct 10, 2017
  * It version introduced did you mean? feature for ri command:
    ruby/rdoc#533
  * Removed obbsoleted ruby_token.rbb.
    [Bug #13990][ruby-core:83180]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60146 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@aycabta aycabta deleted the support-did_you_mean branch October 10, 2017 02:11
mrkn pushed a commit to mrkn/ruby that referenced this pull request Dec 1, 2017
  * It version introduced did you mean? feature for ri command:
    ruby/rdoc#533
  * Removed obbsoleted ruby_token.rbb.
    [Bug #13990][ruby-core:83180]

git-svn-id: svn+ssh://svn.ruby-lang.org/ruby/trunk@60146 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distance recommendations for ri
3 participants