Fix for warnings on Ruby 2.5 in ERB binding #544
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ERB
requires variable context asBinding
object andDarkfish
usesKernel#binding
for it, but it causes warnings "assigned but unused variable" on Ruby 1.9 or later, so there ware "suppress 1.9.3 warning" code like below:The
variable
variable is assigned but unused at this scope and used insideERB
template, so the double assign ofvariable
is for suppress the warning.This code causes warning "assigned but unused variable" on Ruby 2.5 again. I fixed it with
Binding#local_variable_set
for "use" variable.This Pull Request removes Ruby 2.5 warnings in tests below: