Remove unnecessary condition of RDoc::TokenStream.to_html #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RDoc::TokenStream.to_html checks that :on_op and EXPR_ARG token comes for treating it as identifier but the case never come because RDoc::RipperStateLex#get_op_tk set :on_ident and EXPR_ARG when `:on_op` as identifier before RDoc::TokenStream.to_html.
|
I confirmed to the same result with master branch applied to patch additional test of this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RDoc::TokenStream.to_htmlchecks that:on_opandEXPR_ARGtoken comes for treating it as identifier but the case never come becauseRDoc::RipperStateLex#get_op_tkset:on_identandEXPR_ARGwhen:on_opas identifier beforeRDoc::TokenStream.to_html.