Skip to content

appveyor.yml - add VS image info to build log, Ruby 2.6 [skip travis] #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2019

Conversation

MSP-Greg
Copy link
Contributor

@MSP-Greg MSP-Greg commented May 5, 2019

No description provided.

@MSP-Greg
Copy link
Contributor Author

MSP-Greg commented May 5, 2019

Ruby trunk failed. The build is done three times a day, and saves three files. Every 50 to 100 builds, a file is missing. Last build, it was the actual build archive. I forced a build, and (of course) the three artifacts exist.

@aycabta
Copy link
Member

aycabta commented May 6, 2019

I tried 2.6 on my AppVeyor yesterday too, and it succeeded. A previous test of master also succeeded. OK, I understood what you want to do and I think it's correct. The failures on AppVeyor are just an AppVeyor's strange behavior...

I don't think much about it I just do it, and I'm going to see how it goes for a while.

@aycabta aycabta merged commit f17158c into ruby:master May 6, 2019
@aycabta
Copy link
Member

aycabta commented May 6, 2019

@MSP-Greg MSP-Greg deleted the av-img-2.6 branch May 6, 2019 02:13
@MSP-Greg
Copy link
Contributor Author

MSP-Greg commented May 6, 2019

@aycabta

As mentioned, the trunk failure here in the PR was AppVeyor's strange behavior...

But, I took a look at when there were trunk build issues (both Appveyor & Travis), on 15-Feb. I don't think the Travis build is tested, but trunk will always load a passing build, even if more recent builds are failing. Odd thing, the failure here was when building an extension gem (racc), and the build code was looking for defines.h in include/ruby-2.7.0, but it's always been in include/ruby-2.7.0/ruby. Obviously, it's been fixed...

Anyway, rather than commenting out trunk, in Appveyor:

matrix:
  allow_failures:
    - ruby_version: _trunk

Feel free to ping me if there are windows issues. Thanks for your work here and in reline. It was almost passing all the readline tests last time I checked.

JFYI, on Windows, trunk, 2.5 & 2.6 include readline.so, but also include rb-readline, and have it enabled. I look forward to replacing rb-readline with reline...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants