Fix links to headings #721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous change made the header's id be fully referenced (for the sidebar I believe) but this broke links to them. This fixes the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous change made the header's id be fully referenced (for the sidebar I believe) but this broke links to them.
You can see the issue in the doc for Links: https://ruby.github.io/rdoc/RDoc/Markup.html#class-RDoc::Markup-label-Links. In the 4th paragraph, there is a link
Links at RDoc::Markup, which link to#label-Links. You can scroll and then click on it to see that it does nothing. That's because the ID of the header is actuallyclass-RDoc::Markup-label-LinksThis change fixes it.