-
Notifications
You must be signed in to change notification settings - Fork 5.5k
faster String#strip #2815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
faster String#strip #2815
Conversation
Promising result! However, file arrangement seems strange. Headers under include/ are to be installed by |
hi @shyouhei There're more opportunities where we could make core operations significantly faster, but at the cost of a more complicated code. There has to be a duplication if we want a fast variant for other architectures like ARM. In this case, the original (slow) version is used. I would like to know if those optimizations are acceptable to the ruby-core? btw I took inspiration from @casperisfine 's work at Shopify#2 (fastvalidate) which is more important for real-world performance. |
I'd like to know this as well, that's why I have done a private PR first. I might open a ticket on Redmine to ask wether SIMD usage would be acceptable. |
Yes, @casperisfine could you to open a ticket, so that I can 👍 there as well? I believe those vectorization techniques are worth added into the core. Of course there must be cost versus merit debates so discussions should be there for each of them but in general, I see no reason to reject those speedups. @ahorek for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though we need to wait for the redmine discussions, the patch itself nonetheless looks good to me now. 👍
an experiment to make String#strip faster