feat: upgrade to node 24

[chenrui333]

actions/runner#3600 (comment)

---

need a major version bump after the PR merge

[eregon]

Thank you for the PR.
As discussed in #332 and other places though I don't want to bump the action's major version for this, in fact we did not for 12->16 and 16->20 and had no issues. And that saved every user using ruby/setup-ruby@v1 to have to update that line needlessly.

[eregon]

What does this achieve? Force actually using node 24+?
I'm not sure of the value, besides finding that the lint job was using an older node.

Also IIRC there is some env var or config for runners to ignore the using: 'node24' directive, I don't necessarily want to prevent using that.

[chenrui333]

This just matches with node24 in action.yml (yeah, it would force the runner to be upgraded)

Also IIRC there is some env var or config for runners to ignore the using: 'node24' directive, I don't necessarily want to prevent using that.

I dont think I ever saw it before

[chenrui333]

technically this engine constraint should be there before too (but I guess setup-* actions are just adding this time)

[eregon]

It seems to be ACTIONS_RUNNER_FORCE_ACTIONS_NODE_VERSION (actions/runner#1911).
I suspect this change will break if someone uses that to force running an older node.
But, we can try and easily revert it if necessary.

[chenrui333]

And that saved every user using ruiby/setup-ruby@v1 to have to update that line needlessly.

but from the runner perspective, it is technically not compatible (this is semantics to help people upgrade the action runners, for projects using github hosted runners, it wont feel difference)

[eregon]

And that saved every user using ruby/setup-ruby@v1 to have to update that line needlessly.

but from the runner perspective, it is technically not compatible (this is semantics to help people upgrade the action runners, for projects using github hosted runners, it wont feel difference)

I assume self-hosted runners need to be kept up to date anyway for various reasons (e.g. otherwise some core github actions might no longer work, etc). So it seems no or little problem for them.
OTOH, asking to update every usage of ruby/setup-ruby@v1 (and that specific usage is meant to be good as-is forever) to ruby/setup-ruby@v2 is annoying lots of people for absolutely no valid reason (e.g. I do get annoyed when having to update actions/checkout and there is no actual breaking change for workflows so it's a pointless major version bump from the POV of users).

[eregon]

Reverting this for now as it seems to cause issues for many self-hosted runners and I don't see a need to update yet, it can be done later, see #806 (comment).