Skip to content

Why test/{executable,lib,unit}/* are not included in the gem file? #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
junaruga opened this issue Jan 10, 2017 · 4 comments · Fixed by #207
Closed

Why test/{executable,lib,unit}/* are not included in the gem file? #205

junaruga opened this issue Jan 10, 2017 · 4 comments · Fixed by #207
Assignees
Labels

Comments

@junaruga
Copy link
Contributor

Why are only test/functional/* files included in the gem file?

coderay.gemspec

s.files = git ls-files -- lib/* test/functional/* Rakefile #{readme_file} MIT-LICENSE.split("\n")
s.test_files = git ls-files -- test/functional/*.split("\n")

Why test/{executable,lib,unit}/* are not included?

@korny
Copy link
Member

korny commented Jan 15, 2017

You're right, that doesn't make sense. I think tests should not be part of the gem distribution at all though. What's your opinion?

@korny korny self-assigned this Jan 15, 2017
@korny korny added the Tests label Jan 15, 2017
@junaruga
Copy link
Contributor Author

junaruga commented Jan 15, 2017

You're right, that doesn't make sense. I think tests should not be part of the gem distribution at all though. What's your opinion?

My opinion is same with you.
The tests should not be part of the gem distribution.
And Rakefile too.

@junaruga
Copy link
Contributor Author

junaruga commented Mar 6, 2017

Hi @korny can you check my PR #207 ? Thanks.

@korny korny closed this as completed in #207 Mar 9, 2017
@korny
Copy link
Member

korny commented Mar 9, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants