Error "update_depot_tools_toggle.py" building libv8 ruby gem

[stefanahman]

Hello,

I'm trying to build the libv8 ruby gem in our CI. All of a sudden, I'm getting this error:

________ running 'vpython third_party/depot_tools/update_depot_tools_toggle.py
--disable' in
'/home/semaphore/dos/vendor/bundle/ruby/2.5.0/gems/libv8-8.4.255.0/vendor'
/home/semaphore/dos/vendor/bundle/ruby/2.5.0/gems/libv8-8.4.255.0/vendor/depot_tools/.cipd_bin/.cipd/pkgs/0/fI6WggdkRyN1r91MnTeApc2_gyTtXfYpueHZVLcaF8gC/vpython:
could not resolve options: failed to resolve Python script: stat
/home/semaphore/dos/vendor/bundle/ruby/2.5.0/gems/libv8-8.4.255.0/vendor/third_party/depot_tools/update_depot_tools_toggle.py:
no such file or directory
Error: Command 'vpython third_party/depot_tools/update_depot_tools_toggle.py
--disable' returned non-zero exit status 1 in
/home/semaphore/dos/vendor/bundle/ruby/2.5.0/gems/libv8-8.4.255.0/vendor
Running: gclient root
Running: gclient config --spec 'solutions = [
  {
    "name": "v8",
    "url": "https://chromium.googlesource.com/v8/v8.git",
    "deps_file": "DEPS",
    "managed": False,
    "custom_deps": {},
  },
]
'
Running: gclient sync --with_branch_heads
Subprocess failed with return code 2.
/home/semaphore/dos/vendor/bundle/ruby/2.5.0/gems/libv8-8.4.255.0/ext/libv8/builder.rb:83:in
`block in setup_build_deps!': unable to fetch v8 source (RuntimeError)
from
/home/semaphore/dos/vendor/bundle/ruby/2.5.0/gems/libv8-8.4.255.0/ext/libv8/builder.rb:81:in
`chdir'
from
/home/semaphore/dos/vendor/bundle/ruby/2.5.0/gems/libv8-8.4.255.0/ext/libv8/builder.rb:81:in
`setup_build_deps!'
from
/home/semaphore/dos/vendor/bundle/ruby/2.5.0/gems/libv8-8.4.255.0/ext/libv8/builder.rb:40:in
`build_libv8!'
from
/home/semaphore/dos/vendor/bundle/ruby/2.5.0/gems/libv8-8.4.255.0/ext/libv8/location.rb:24:in
`install!'
	from extconf.rb:7:in `<main>'

extconf failed, exit code 1

[jdelStrother]

Weirdly, ours has also suddenly started failing in our Github Actions CI.

  /home/runner/work/audioboom-web/audioboom-web/vendor/bundle/ruby/2.6.0/gems/libv8-7.3.492.27.1/ext/libv8
  /opt/hostedtoolcache/Ruby/2.6.6/x64/bin/ruby -I
  /opt/hostedtoolcache/Ruby/2.6.6/x64/lib/ruby/2.6.0 -r
  ./siteconf20201210-8200-18jih01.rb extconf.rb
  creating Makefile
  WARNING: Your metrics.cfg file was invalid or nonexistent. A new one will be
  created.
  
  ________ running 'git -c core.deltaBaseCacheLimit=2g clone --no-checkout
  --progress https://chromium.googlesource.com/v8/v8.git

....

  Traceback (most recent call last):
  File
  "/home/runner/work/audioboom-web/audioboom-web/vendor/bundle/ruby/2.6.0/gems/libv8-7.3.492.27.1/vendor/depot_tools/metrics.py",
  line 266, in print_notice_and_exit
      yield
  File
  "/home/runner/work/audioboom-web/audioboom-web/vendor/bundle/ruby/2.6.0/gems/libv8-7.3.492.27.1/vendor/depot_tools/gclient.py",
  line 3155, in <module>
      sys.exit(main(sys.argv[1:]))
  File
  "/home/runner/work/audioboom-web/audioboom-web/vendor/bundle/ruby/2.6.0/gems/libv8-7.3.492.27.1/vendor/depot_tools/gclient.py",
  line 3141, in main
      return dispatcher.execute(OptionParser(), argv)
  File
  "/home/runner/work/audioboom-web/audioboom-web/vendor/bundle/ruby/2.6.0/gems/libv8-7.3.492.27.1/vendor/depot_tools/subcommand.py",
  line 252, in execute
      return command(parser, args[1:])
  File
  "/home/runner/work/audioboom-web/audioboom-web/vendor/bundle/ruby/2.6.0/gems/libv8-7.3.492.27.1/vendor/depot_tools/gclient.py",
  line 2699, in CMDsync
      ret = client.RunOnDeps('update', args)
  File
  "/home/runner/work/audioboom-web/audioboom-web/vendor/bundle/ruby/2.6.0/gems/libv8-7.3.492.27.1/vendor/depot_tools/gclient.py",
  line 1755, in RunOnDeps
      gn_args_dep.WriteGNArgsFile()
  File
  "/home/runner/work/audioboom-web/audioboom-web/vendor/bundle/ruby/2.6.0/gems/libv8-7.3.492.27.1/vendor/depot_tools/gclient.py",
  line 1022, in WriteGNArgsFile
      with open(os.path.join(self.root.root_dir, self._gn_args_file), 'w') as f:
  IOError: [Errno 2] No such file or directory:
  '/home/runner/work/audioboom-web/audioboom-web/vendor/bundle/ruby/2.6.0/gems/libv8-7.3.492.27.1/vendor/build/config/gclient_args.gni'
  Running: gclient root
  Running: gclient config --spec 'solutions = [
    {
      "url": "https://chromium.googlesource.com/v8/v8.git",
      "managed": False,
      "name": "v8",
      "deps_file": "DEPS",
      "custom_deps": {},
    },
  ]
  '
  Running: gclient sync --with_branch_heads
  Subprocess failed with return code 1.
  /home/runner/work/audioboom-web/audioboom-web/vendor/bundle/ruby/2.6.0/gems/libv8-7.3.492.27.1/ext/libv8/builder.rb:83:in
  `block in setup_build_deps!': unable to fetch v8 source (RuntimeError)
  from
  /home/runner/work/audioboom-web/audioboom-web/vendor/bundle/ruby/2.6.0/gems/libv8-7.3.492.27.1/ext/libv8/builder.rb:81:in
  `chdir'
  from
  /home/runner/work/audioboom-web/audioboom-web/vendor/bundle/ruby/2.6.0/gems/libv8-7.3.492.27.1/ext/libv8/builder.rb:81:in
  `setup_build_deps!'
  from
  /home/runner/work/audioboom-web/audioboom-web/vendor/bundle/ruby/2.6.0/gems/libv8-7.3.492.27.1/ext/libv8/builder.rb:40:in
  `build_libv8!'
  from
  /home/runner/work/audioboom-web/audioboom-web/vendor/bundle/ruby/2.6.0/gems/libv8-7.3.492.27.1/ext/libv8/location.rb:24:in
  `install!'
  	from extconf.rb:7:in `<main>'

I'm not sure why it's suddenly started trying to build libv8 from source rather than using the binary, still investigating... 😕

[jdelStrother]

Ugh, think it's because bundler 2.2 has just come out, and it's fetching the build-from-source gem rather than the prepackaged binary.

[stefanahman]

Ye, I'm locking bundler to version 2.1.4 for now. Thanks @jdelStrother!

[deivid-rodriguez]

Hi!

I'm really sorry the bundler release caused issues for you 🙏.

And I don't know why this is happening, because if anything, the new version was expected to choose prepackaged binaries more smartly, but it sounds like it's doing the exact opposite here.

What steps can I run to see the issue for myself and investigate it?

[filipkis]

For me somehow installing gem install bundler -v 2.1.4 was not enough (this is on Github Actions workflow so there shouldn't be any other bundler there). The bundler install command still said Using bundler 2.2.0. However running it with bundler _2.1.4_ install finally worked.

[deivid-rodriguez]

I think that's because ruby/setup-ruby installs the latest bundler automatically for you. You can opt out of that by passing bundler: none to the action, and then manually installing 2.1.4.

[jdelStrother]

What steps can I run to see the issue for myself and investigate it?

I'm finding it surprisingly hard to come up with a small reproduction. Anyone else had better luck? @stefanahman you're not also using ruby/setup-ruby in Github Actions, right?

[JunichiIto]

You can opt out of that by passing bundler: none to the action, and then manually installing 2.1.4.

bundler: "2.1.4" works instead of passing bundler: none to the action, and then manually installing 2.1.4.

e.g.

- name: Set up Ruby
  uses: ruby/setup-ruby@v1
  with:
    # NOTE: Bundler 2.2.0 fails to install libv8
    # https://github.com/rubyjs/libv8/issues/310
    bundler: "2.1.4"
    bundler-cache: true

UPDATE
ruby/setup-ruby#127 allows setup-ruby to install the same Bundler version as Gemfile.lock with bundler: "Gemfile.lock" option.

- name: Set up Ruby
  uses: ruby/setup-ruby@v1
  with:
    bundler: "Gemfile.lock"
    bundler-cache: true

[deivid-rodriguez]

Oh neat, I didn't know that feature!

[deivid-rodriguez]

Maybe it was added recently, because from the current docs I wouldn't expect that to be supported.