Add tests for mutability #574
Open
+144
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehildenb
reviewed
May 9, 2025
| PROVE_RS_SHOW_SPECS = [ | ||
| 'local-raw-fail', | ||
| ] | ||
| PROVE_RS_SHOW_SPECS = ['local-raw-fail', 'interior-mut-fail', 'interior-mut2-fail', 'interior-mut3-fail'] |
There was a problem hiding this comment.
We should do these one per line instead. Will make it easier to add/delete them.
|
Can we rebase this on master to get current |
dkcumming
force-pushed
the
dc/add-mut-tests
branch
from
e46665a to
ac342de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tests to examine the boundaries of mutability and immutability, not all of these use
unsafebut only the ones I listed as unsafe do we annotate unsafe directly:RefCell(stuck onRvalue::AddressOf)Cell(stuck onRvalue::AddressOf)UnsafeCell(stuck onRvalue::AddressOf)We discussed the possibility of adding tests that show demonstrate immutable field of mutable structs, but this is not possible in rust. There is a notion of private fields if structs come from other modules, but this is not the same as mutability.