Provide the same set of arith impls as stdlib #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CAD97 could you watch the repo so that I don't need to tag you explictelly on every PR? :) |
|
The reason is that I've got the code that does on my machine but haven't pushed it yet because you've been moving so fast :P |
|
Ah, feel free to merge or to push your version :) |
bors bot
added a commit
that referenced
this pull request
Mar 13, 2020
8: Provide ref-transparent ops for TextSize r=matklad a=CAD97 Counter-proposal to #7. Basically the same set of impls, but set up slightly differently. Co-authored-by: CAD97 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But is there specific reason to do this?
Also, are there any coherence implementations for using blanket impls for
OpAssign/Sum, instead of just writing the two specific impls? Would it prevent downstream crates from adding some impls they otherwise would be able to add?