-
Notifications
You must be signed in to change notification settings - Fork 15
add a vendor feature #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add a vendor feature #119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Would you mind squash the fixup commits so the feature for denoise is split from the feature for the vendor code and the overall code cleanup?
rustfmt seems unhappy and the CI seems to fail to build speexdsp |
The CI should be fixed. Tho i'm not sure if the vendored feature should be enabled in CI |
this line will have no effect now |
I enabled each features manually expect the vendored ones, so the previous behavior is back. Tho, in the long run, i think it would be simplier if the sys crate take the env variable. |
No description provided.