Skip to content

Conversation

wiiznokes
Copy link

No description provided.

Copy link
Member

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Would you mind squash the fixup commits so the feature for denoise is split from the feature for the vendor code and the overall code cleanup?

@lu-zero
Copy link
Member

lu-zero commented Aug 18, 2025

rustfmt seems unhappy and the CI seems to fail to build speexdsp

@wiiznokes
Copy link
Author

The CI should be fixed. Tho i'm not sure if the vendored feature should be enabled in CI

@wiiznokes
Copy link
Author

./configure --disable-sse --prefix=$HOME/$SPEEX_DIR

this line will have no effect now

@wiiznokes
Copy link
Author

./configure --disable-sse --prefix=$HOME/$SPEEX_DIR

this line will have no effect now

I enabled each features manually expect the vendored ones, so the previous behavior is back. Tho, in the long run, i think it would be simplier if the sys crate take the env variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants