Skip to content

Allow to configure alternate mirrors #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tnull opened this issue Feb 18, 2023 · 1 comment · Fixed by #107
Closed

Allow to configure alternate mirrors #106

tnull opened this issue Feb 18, 2023 · 1 comment · Fixed by #107

Comments

@tnull
Copy link
Contributor

tnull commented Feb 18, 2023

It would be nice if we could point the crate to alternate mirrors rather than having https://bitcoincore.org/ hard-coded.

Main motivation is that we in LDK recently started seeing CI failures that seem to come from Github CI being unable to connect to https://bitcoincore.org/:

error: failed to run custom build command for `bitcoind v0.28.1`

Caused by:
  process didn't exit successfully: `/home/runner/work/rust-lightning/rust-lightning/target/debug/build/bitcoind-db625c734508c201/build-script-build` (exit status: 101)
  --- stdout
  filename:bitcoin-23.0-x86_64-linux-gnu.tar.gz version:23.0 hash:2cca490c1f2842884a3c5b0606f179f9f937177da4eadd628e3f7fd7e25d26d0
  url:https://bitcoincore.org/bin/bitcoin-core-23.0/bitcoin-23.0-x86_64-linux-gnu.tar.gz

  --- stderr
  thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Transport(Transport { kind: Io, message: None, url: Some(Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("bitcoincore.org")), port: None, path: "/bin/bitcoin-core-23.0/bitcoin-23.0-x86_64-linux-gnu.tar.gz", query: None, fragment: None }), source: Some(Custom { kind: TimedOut, error: "timed out reading response" }) })', /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/bitcoind-0.28.1/build.rs:106:43

If these issues continue to appear we'd be interested in exploring hosting our own mirror to make the bitcoind/electrsd based tests more robust.

@RCasatta
Copy link
Collaborator

Make sense to allow to override the download endpoint from an env var.
PR welcome, or I'll do it sometime whoever arrives first :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants