Skip to content

Make download endpoint configurable #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Feb 20, 2023

Closes #106.

In this PR we make the download endpoint configurable. If this is accepted, I'll see to open an equivalent PR towards electrsd.

Copy link
Collaborator

@RCasatta RCasatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not yet sure why we have an error in the ci for 1.41.1...

@tnull
Copy link
Contributor Author

tnull commented Feb 28, 2023

not yet sure why we have an error in the ci for 1.41.1...

Mh, seems linux-raw-sys has an MSRV of 1.48.0, but I'm currently not seeing where this dependency is coming from, as it's not listed in cargo tree --all-features.

@RCasatta
Copy link
Collaborator

RCasatta commented Mar 3, 2023

This MR is clearly not causing the issue with the CI

I would have preferred the "f typo" commit was squashed, but I would like to avoid the roundtrip for it. I am going to merge

ACK 56f2321

@RCasatta RCasatta merged commit 56f2321 into rust-bitcoin:master Mar 3, 2023
@RCasatta
Copy link
Collaborator

RCasatta commented Mar 3, 2023

not yet sure why we have an error in the ci for 1.41.1...

Mh, seems linux-raw-sys has an MSRV of 1.48.0, but I'm currently not seeing where this dependency is coming from, as it's not listed in cargo tree --all-features.

apparently the dep linux-raw-sys is in the dep tree only for 1.41.1 but that rust toolchain hasn't a tree subcommand... I manually searched for it, MR coming...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to configure alternate mirrors
2 participants