Skip to content

Add Bitcoin Core v25.1 #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

andrewtoth
Copy link
Contributor

No description provided.

@RCasatta
Copy link
Collaborator

ACK e5ec8f4

Thanks

Usually, only the greater minor version is kept (so we will remove 25.0) to keep the number of features manageable...
But we can remove later on

@RCasatta
Copy link
Collaborator

...CI error is unrelated to this MR and will be fixed separately

@RCasatta RCasatta merged commit e5ec8f4 into rust-bitcoin:master Oct 26, 2023
@andrewtoth andrewtoth deleted the bitcoin_25_1 branch October 26, 2023 11:52
@andrewtoth
Copy link
Contributor Author

But we can remove later on

Err sorry, but removing features is a breaking change. Should bump major version for each feature removal I think?

@RCasatta
Copy link
Collaborator

Yeah, It should be major but in the past I did a minor version changes for this kind of stuff since I am stuck with the 0.* version

I should probably do a minor to major version migration like Bitcoin core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants