Skip to content

simplify error message output for unsupported version output #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

GideonBature
Copy link
Contributor

Revised the output for unrecognised versions to:

  verify v1234

  Unrecognised version: v1234 (supported versions: v17 - v28)

This removes the noise of listing all versions by displaying a concise version range.

Closes #65

@GideonBature GideonBature force-pushed the verify-unsupported_versions branch 2 times, most recently from 217a981 to 69aae16 Compare April 4, 2025 11:12
@GideonBature GideonBature force-pushed the verify-unsupported_versions branch from 69aae16 to a5efb11 Compare April 4, 2025 11:16
Copy link

@AdamuAbba AdamuAbba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK #a5efb11; successfully ran a local test.

Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a5efb11

@tcharding tcharding merged commit 870efdf into rust-bitcoin:master Apr 4, 2025
27 checks passed
@tcharding
Copy link
Member

Awesome, thanks.

@GideonBature GideonBature deleted the verify-unsupported_versions branch May 31, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

verify: Output for unsupported version is noisey
3 participants