Overhaul integration testing #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been a while since I started this project and in that time the testing strategy has evolved. Overhaul the integration tests: - Use new strategy of using explicit types (vtype, mtype, and error type) so that the integration tests ensure we re-exported things correctly. - Remove a bunch of feature gating, thereby improving test coverage. - A few other little things along the way. This patch is neigh on impossible to review with any confidence - as is typical in this lib.
tcharding
force-pushed
the
04-09-types-re-exports
branch
from
52064f8 to
830a05a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been a while since I started this project and in that time the testing strategy has evolved.
Overhaul the integration tests:
Use new strategy of using explicit types (vtype, mtype, and error type) so that the integration tests ensure we re-exported things correctly.
Remove a bunch of feature gating, thereby improving test coverage.
A few other little things along the way.
This patch is neigh on impossible to review with any confidence - as is typical in this lib.
Close: #122