Implement pruneblock method and test

[GideonBature]

Going by the conversations with tcharding for PR #116 on implementing one method at a time for easier review: This is the first method implementation pruneblockchain which is a specific type that returns a standard type (numeric). Once this is approved, I’ll proceed with the remaining ones.

[tcharding]

Looks pretty good man. Can you strip out all the unrelated changes then I'll do another review. Keep at it man, you're killing it.

[tcharding]

Please undraft only after you've seen to all previous review suggestions. Thanks

[tcharding]

Still has formatting changes in it.

[tcharding]

Hey mate, I just merged #117, I've been working on that for a while now. As such it has some of my latest ideas in it. In general if you want to copy something you might want to reach into the raw_transactions modules first.

[GideonBature]

Hey mate, I just merged #117, I've been working on that for a while now. As such it has some of my latest ideas in it. In general if you want to copy something you might want to reach into the raw_transactions modules first.

Alright, I am going to do that... Thank you. The work you did is massive.

[tcharding]

Please squash the commits into a single one.

[tcharding]

Looking good, couple more things. Stick at it!

[GideonBature]

I am having a hard time squashing the commits, the one having the merge after resolving conflict seems to not appear for me to squash to the original one that was there, so I want to ask if there is a way to resolve that, or If I should close this PR and open a fresh PR with the final stage of this PR?

[tcharding]

Yeah something strange has happened to the git index on this branch. I managed to get it kind of sane again using the following series of commands.

• git reset --hard @~
• git clean -fd

Then I was able to run git rebase master. This leaves a bunch of conflicts in types. If I was you I'd just hard reset types and re-do it manually but that is just my opinion.

[GideonBature]

Yeah something strange has happened to the git index on this branch. I managed to get it kind of sane again using the following series of commands.

• git reset --hard @~
• git clean -fd

Then I was able to run git rebase master. This leaves a bunch of conflicts in types. If I was you I'd just hard reset types and re-do it manually but that is just my opinion.

Noted... I will try your opinion... Thank you.

[GideonBature]

Yeah something strange has happened to the git index on this branch. I managed to get it kind of sane again using the following series of commands.

• git reset --hard @~
• git clean -fd

Then I was able to run git rebase master. This leaves a bunch of conflicts in types. If I was you I'd just hard reset types and re-do it manually but that is just my opinion.

This worked... Thank you :).

[tcharding]

Ugh, bro! Now you have changes from the v29 PR in there. Can you flick through your diffs before you push them to help catch these things.

[tcharding]

This is getting clean! One final thing, and I wouldn't normally ask but because this PR is a test run for more of the same then we should get it perfect. The integration test is not in order (should be below the blockchain__precious_block test). Then we can merge, well done man.

[GideonBature]

This is getting clean! One final thing, and I wouldn't normally ask but because this PR is a test run for more of the same then we should get it perfect. The integration test is not in order (should be below the blockchain__precious_block test). Then we can merge, well done man.

smiles, honestly, I thought of the order too, but I thought best I hear it from you. Thank you so much for the reviews, sometimes I feel I am stressing you. I have learnt a lot from the reviews you gave me, and will make sure I do the remaining ones the right way.

[tcharding]

No stress man, if you apply effort and learn from your mistakes then we all win.

[tcharding]

ACK bbcec24