client: Move types to version specific module #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
05-11-client-types
branch
5 times, most recently
from
00143f6 to
9266a31
Compare
|
I'll come back after the weekend. |
tcharding
force-pushed
the
05-11-client-types
branch
from
9266a31 to
e1bfe30
Compare
Currently we have a bit of confusion around types that are defined and used by the various client version modules. - Some currently don't change e.g., `Input` - Some are due to change in v29 e.g., `TemplateRequest` - Some change already e.g. `AddressVersion` And to make matters worse, I did 'custom' re-exports in `node` which is very confusing when one is reading code in `client`. Put all `client` defined types in the version module they first appear in and re-export them as we do for types from `types`. Then use the type naked (without qualifying the path).
tcharding
force-pushed
the
05-11-client-types
branch
from
e1bfe30 to
1c8f746
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have a bit of confusion around types that are defined and used by the various client version modules.
InputTemplateRequestAddressTypeAnd to make matters worse, I did 'custom' re-exports in
nodewhich is very confusing when one is reading code inclient.Put all
clientdefined types in the version module they first appear in and re-export them as we do for types fromtypes. Then use the type naked (without qualifying the path).