types: Clean up the ScriptPubkey type
#174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
changed the title
ScriptPubkey type
tcharding
force-pushed
the
05-15-fix-script-pubkey
branch
from
63fc880 to
f255db4
Compare
The `ScriptPubkey` type is a type that is returned by Core in various places. It seems like the Core devs put a fair bit of effort into it (probably because of this) and when the type changed in v22 it was changed in a way that was completely backwards compatible. I failed to fully understand this when first adding the type. With this patch applied there is now only one `ScriptPubkey` type (in `libr.s`) and also we add a model type. The `ScriptPubkey` type is unusual in that its fields can be used to create `TxOut` if tx value is known - which for example in `GetTxOut` it is. So here we also remove the v22 `GetTxOut` type since it only existed because of the perceived difference in `ScriptPubkey` which no longer exists. Fix: rust-bitcoin#166
tcharding
force-pushed
the
05-15-fix-script-pubkey
branch
from
f255db4 to
730ed23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ScriptPubkeytype is a type that is returned by Core in various places. It seems like the Core devs put a fair bit of effort into it (probably because of this) and when the type changed in v22 it was changed in a way that was completely backwards compatible.I failed to fully understand this when first adding the type.
With this patch applied there is now only one
ScriptPubkeytype (inlibr.s) and also we add a model type.The
ScriptPubkeytype is unusual in that its fields can be used to createTxOutif tx value is known - which for example inGetTxOutit is.So here we also remove the v22
GetTxOuttype since it only existed because of the perceived difference inScriptPubkeywhich no longer exists.Fix: #166