Run verify in CI
#35
Merged
Run verify in CI
#35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `verify` crate is a dev tool and should not have been included in the workspace because it has no lock file requirements. Exclude `verify` from the workspace and update the lock files.
Merged
|
We can do this, but FYI if you remove stuff from the workspace I will never test it again because it's effectively invisible to me. |
|
hmm, I'll put some thought into whether we want to actually run |
Add a version arg to the `verify` command. Use `clap` to do so.
Add a job that runs `verify --all` to CI.
|
Gotta run, if this goes red don't waist your time on in @apoelstra I'll come back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
verifycrate is a dev tool and should not have been included in the workspace because it has no lock file requirements.Exclude
verifyfrom the workspace and update the lock files and add a job that runs it from CI.