Skip to content

Remove YAML support #473

Closed
Closed
@matthiasbeyer

Description

@matthiasbeyer
Member
          FWIW, it seems that the [yaml support has become unmaintained](https://github.com/chyh1990/yaml-rust/issues/160), no commits since July 2021. The developer doesn't have much activity on Github (_last active Sep 2022_).

Originally posted by @polarathene in #466 (comment)


I know that YAML is widely used as a configuration language in some ecosystems, so I am a bit undecided about this one. If someone wants to go ahead and remove YAML support, though, I would merge such a patchset.

Activity

polarathene

polarathene commented on Oct 7, 2023

@polarathene
Collaborator

It might be unmaintained, but as long as it's working and not causing any problems in config-rs that should be fine to leave as-is? Alternatively instead of removing YAML support entirely, it only really requires changing the format/yaml.rs file right?

There's an actively developed serde yaml crate, although it's unclear if it's at parity feature wise.

matthiasbeyer

matthiasbeyer commented on Oct 8, 2023

@matthiasbeyer
MemberAuthor

Ah yeah, I didn't see that. I would prefer switching to another YAML implementation rather than removing support completely.

polarathene

polarathene commented on Oct 20, 2023

@polarathene
Collaborator

Just a heads-up, not sure if you get notifications for new PRs but #474 has been open without any engagement nearing two weeks now.

If you merge #474 first, I'll rebase #472 to accomodate, otherwise #472 has a separate commit focused on the YAML support and switch, which should be fine as you prefer merge commits over squash commits, there is little advantage then from merging #474 . Both PRs cross-reference each other, so that information on #474 shouldn't be difficult to find (as those additional details aren't in the commit message).

added this to the 0.14.0 milestone on Oct 27, 2023
modified the milestones: 0.14.0, 0.15.0 on Feb 1, 2024
0rzech

0rzech commented on Mar 27, 2024

@0rzech
Contributor

Ah yeah, I didn't see that. I would prefer switching to another YAML implementation rather than removing support completely.

Apparently there's the yaml-rust2 drop-in replacement that is actively maintained. I've created #554 with this change to fix #553 which arose in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Participants

      @matthiasbeyer@0rzech@polarathene

      Issue actions

        Remove YAML support · Issue #473 · rust-cli/config-rs