You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this seems somewhat redundant, customformat or default format is used, i do not quite understand why both exist at the same time.
tbh i don't fully understand the intent behind this entire pr.
i do not think the builder which modifies defaultformat would ever be useful for any user of the library that wants a custom formatter. no functions interact at all. i think those two should be fully decoupled.
this seems somewhat redundant, customformat or default format is used, i do not quite understand why both exist at the same time.
tbh i don't fully understand the intent behind this entire pr.
This PR serves the following roles
Makes the intent clearer in what is associated with the default formatter and not the custom formatter
Allows callers to create their own formatters on top of ConfigurableFormat
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to allow people to compose more complex formatting options (e.g. for #349) by exposing the built-in formatting
A breaking change was split out into #361