This repository was archived by the owner on Mar 1, 2019. It is now read-only.
loader: Change RUSTC env var behavior #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously environmental variables were determined at compile time (not desired), and if not present, the call to rustc to get the sysroot would fail. This commit changes the semantics to shell out to rustc in a more predictable fashion.
|
Tests are not failing from this commit from what I can tell. Git bisect shows that 4cb03ba introduced the failing tests. |
|
Thanks for fixing this! Yeah, failing tests are due to some missing test data which should be fixed now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously environmental variables were determined at compile time (not desired), and if not present, the call to rustc to get the sysroot would fail. This commit changes the semantics to shell out to rustc in a more predictable fashion.
When merged this will fix #119. After this is released, I can update the RLS's version of rls-analysis, and eventually get these changes out via rust-lang/rust.