This repository was archived by the owner on Mar 1, 2019. It is now read-only.
Use the length field on rls_span::Range if available
#12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 27, 2017
added 2 commits
April 28, 2017 00:36
This field is more reliable than the `end` position for most editors. In particular emacs has a problem where it does not send a correct end position (`length` is still valid, though)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field is more reliable than the
endposition for most editors.In particular emacs has a problem where it does not send a correct end
position (
lengthis still valid, though)related to rust-lang/rls#281 and rust-dev-tools/rls-span#12