Skip to content

Adding TRANSFER.md instructions for transferring to the REC #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 23, 2024

Conversation

ryan-summers
Copy link
Member

Fixes #23 by adding a new TRANSFER.md file.

@ryan-summers ryan-summers requested a review from eldruin April 30, 2024 08:49
@eldruin
Copy link
Member

eldruin commented Apr 30, 2024

Thank you for writing this!
There is one problem I have hit in the past with regard to publishing permissions, though:

In order to invite a team as an owner one must be a member of that team

So the process is slightly more complicated:

  • If the person wants to join the r-e-c, that should be done first and then the transfer process is as detailed here.
  • If the person does not want to join the r-e-c, crates.io publishing permission must be granted to an individual of the org (they are probably in contact with or know about someone already. Otherwise they can open an issue. Failing that they can contact me, for example).
    • This person can then grant publishing permission to the r-e-c/all team

I did not know you can transfer a repository to an org you do not belong to, though. The documentation seems a bit contradictory to me (you can transfer to anybody by writing their name and they get an email vs. you need permission to create repositories in the target org)

@jamesmunns
Copy link
Member

@eldruin and @ryan-summers, is there anything we can do to get @eldruin's concerns addressed, and get this merged?

@ryan-summers
Copy link
Member Author

Nope, I was out on vacation the last two weeks, which is why I wasn't touching it. Thanks for the reminder though, I'll review the requested changes and get this updated shortly.

@ryan-summers
Copy link
Member Author

Alright, this should be ready for another read-through now. Thanks for the review (+ ping)!

Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for coming back to this.
Just a couple of details left.

ryan-summers and others added 2 commits May 22, 2024 16:34
Co-authored-by: Diego Barrios Romero <[email protected]>
Co-authored-by: Diego Barrios Romero <[email protected]>
@ryan-summers ryan-summers requested a review from eldruin May 22, 2024 14:35
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, there is a formatting mistake where the cargo owner command block is not properly closed due to it being from a review, where github apparently does not support triple quotes.
Could you fix that manually?

@ryan-summers
Copy link
Member Author

Sorry, there is a formatting mistake where the cargo owner command block is not properly closed due to it being from a review, where github apparently does not support triple quotes. Could you fix that manually?

Should be done. Interestingly, Github still rendered it properly with the formatting mistake. Thanks for pointing this out though, should be good now. Feel free to manually update the PR and merge if you'd like as well

Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for following through with this.

@eldruin eldruin merged commit abe8ebb into master May 23, 2024
@eldruin eldruin deleted the feature/transfer-instructions branch May 23, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add detailed instructions for transferring crate ownership to R-E-C
3 participants