This repository was archived by the owner on Jan 24, 2022. It is now read-only.
Update linker script to fix arm-none-eabi-gcc linking. Closes #259 #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @korken89 (rust_highfive has picked a reviewer for you, use r? to override) |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 3, 2020
260: Update linker script to fix arm-none-eabi-gcc linking. Closes #259 r=korken89 a=adamgreig Co-authored-by: Adam Greig <[email protected]>
|
bors r- |
Canceled |
|
I've been investigating a bit further and actually the I definitely think we should still add gcc to the CI scripts. @therealprof any recollection what the purpose of that line was in #207? |
|
@therealprof mentioned that the bug was hit in rust-lld when _stext was offset: rust-lang/rust#65391 I'll do some more tests in that configuration. Also, we should probably add a MSRV run to the CI, perhaps 1.32.0. |
|
Testing with a memory.x-overridden stext shows we do still need the full modification to the linker script. I'm going to close this PR and open a new one just for adding arm-none-eabi-gcc to the CI. Sorry for the noise! |
bors bot
added a commit
that referenced
this pull request
Apr 4, 2020
262: Add testing linker=arm-none-eabi-gcc and MSRV to CI r=therealprof a=adamgreig Replacing #260. This PR extends our current tests with `linker=rust-lld` and `linker=arm-none-eabi-ld` to include `linker=arm-none-eabi-gcc`, since those options are all included in our example [`.cargo/config`](https://github.com/rust-embedded/cortex-m-rt/blob/master/.cargo/config). It looks like another linker only adds a handful of seconds to CI, since most time is spent building dependencies once. It also adds a test with Rust 1.32.0 to the CI as a candidate MSRV. Building with 1.31.0 fails because of the dev-dependency on cortex-m-semihosting 0.3.5: ``` error[E0658]: using the `?` macro Kleene operator for "at most one" repetition is unstable (see issue #48075) --> /home/adam/.cargo/registry/src/github.com-1ecc6299db9ec823/cortex-m-semihosting-0.3.5/src/macros.rs:111:25 | 111 | ($($val:expr),+ $(,)?) => { | ^ error: expected `*` or `+` ``` That's just a test error which end users wouldn't experience, so we could consider making 1.31.0 the MSRV and working around the c-m-semihosting issue. I don't know if there are other 1.31.0 issues. Finally the PR removes the travis check preventing builds on pushes to master. In principle we know that builds to master succeed because bors tests them before pushing, so adding the extra check mostly means we get a well-defined build status from Travis for flags etc. The build times for cortex-m-rt (around 3min overall) are a bit longer than r0 (where we did the same thing), so we could just run a minimal test here instead. I don't think it's a significant overhead given how infrequently we push to master, though. Co-authored-by: Adam Greig <[email protected]>
bors bot
added a commit
that referenced
this pull request
Apr 7, 2020
262: Add testing linker=arm-none-eabi-gcc and MSRV to CI r=therealprof a=adamgreig Replacing #260. This PR extends our current tests with `linker=rust-lld` and `linker=arm-none-eabi-ld` to include `linker=arm-none-eabi-gcc`, since those options are all included in our example [`.cargo/config`](https://github.com/rust-embedded/cortex-m-rt/blob/master/.cargo/config). It looks like another linker only adds a handful of seconds to CI, since most time is spent building dependencies once. It also adds a test with Rust 1.32.0 to the CI as a candidate MSRV. Building with 1.31.0 fails because of the dev-dependency on cortex-m-semihosting 0.3.5: ``` error[E0658]: using the `?` macro Kleene operator for "at most one" repetition is unstable (see issue #48075) --> /home/adam/.cargo/registry/src/github.com-1ecc6299db9ec823/cortex-m-semihosting-0.3.5/src/macros.rs:111:25 | 111 | ($($val:expr),+ $(,)?) => { | ^ error: expected `*` or `+` ``` That's just a test error which end users wouldn't experience, so we could consider making 1.31.0 the MSRV and working around the c-m-semihosting issue. I don't know if there are other 1.31.0 issues. Finally the PR removes the travis check preventing builds on pushes to master. In principle we know that builds to master succeed because bors tests them before pushing, so adding the extra check mostly means we get a well-defined build status from Travis for flags etc. The build times for cortex-m-rt (around 3min overall) are a bit longer than r0 (where we did the same thing), so we could just run a minimal test here instead. I don't think it's a significant overhead given how infrequently we push to master, though. Co-authored-by: Adam Greig <[email protected]>
bors bot
added a commit
that referenced
this pull request
Apr 7, 2020
262: Add testing linker=arm-none-eabi-gcc and MSRV to CI r=therealprof a=adamgreig Replacing #260. This PR extends our current tests with `linker=rust-lld` and `linker=arm-none-eabi-ld` to include `linker=arm-none-eabi-gcc`, since those options are all included in our example [`.cargo/config`](https://github.com/rust-embedded/cortex-m-rt/blob/master/.cargo/config). It looks like another linker only adds a handful of seconds to CI, since most time is spent building dependencies once. It also adds a test with Rust 1.32.0 to the CI as a candidate MSRV. Building with 1.31.0 fails because of the dev-dependency on cortex-m-semihosting 0.3.5: ``` error[E0658]: using the `?` macro Kleene operator for "at most one" repetition is unstable (see issue #48075) --> /home/adam/.cargo/registry/src/github.com-1ecc6299db9ec823/cortex-m-semihosting-0.3.5/src/macros.rs:111:25 | 111 | ($($val:expr),+ $(,)?) => { | ^ error: expected `*` or `+` ``` That's just a test error which end users wouldn't experience, so we could consider making 1.31.0 the MSRV and working around the c-m-semihosting issue. I don't know if there are other 1.31.0 issues. Finally the PR removes the travis check preventing builds on pushes to master. In principle we know that builds to master succeed because bors tests them before pushing, so adding the extra check mostly means we get a well-defined build status from Travis for flags etc. The build times for cortex-m-rt (around 3min overall) are a bit longer than r0 (where we did the same thing), so we could just run a minimal test here instead. I don't think it's a significant overhead given how infrequently we push to master, though. Co-authored-by: Adam Greig <[email protected]>
bors bot
added a commit
that referenced
this pull request
Apr 7, 2020
262: Add testing linker=arm-none-eabi-gcc and MSRV to CI r=therealprof a=adamgreig Replacing #260. This PR extends our current tests with `linker=rust-lld` and `linker=arm-none-eabi-ld` to include `linker=arm-none-eabi-gcc`, since those options are all included in our example [`.cargo/config`](https://github.com/rust-embedded/cortex-m-rt/blob/master/.cargo/config). It looks like another linker only adds a handful of seconds to CI, since most time is spent building dependencies once. It also adds a test with Rust 1.32.0 to the CI as a candidate MSRV. Building with 1.31.0 fails because of the dev-dependency on cortex-m-semihosting 0.3.5: ``` error[E0658]: using the `?` macro Kleene operator for "at most one" repetition is unstable (see issue #48075) --> /home/adam/.cargo/registry/src/github.com-1ecc6299db9ec823/cortex-m-semihosting-0.3.5/src/macros.rs:111:25 | 111 | ($($val:expr),+ $(,)?) => { | ^ error: expected `*` or `+` ``` That's just a test error which end users wouldn't experience, so we could consider making 1.31.0 the MSRV and working around the c-m-semihosting issue. I don't know if there are other 1.31.0 issues. Finally the PR removes the travis check preventing builds on pushes to master. In principle we know that builds to master succeed because bors tests them before pushing, so adding the extra check mostly means we get a well-defined build status from Travis for flags etc. The build times for cortex-m-rt (around 3min overall) are a bit longer than r0 (where we did the same thing), so we could just run a minimal test here instead. I don't think it's a significant overhead given how infrequently we push to master, though. Co-authored-by: Adam Greig <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.