This repository was archived by the owner on Dec 2, 2020. It is now read-only.
Add equivalent of dbg! macro #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added an example as documentation. |
adamgreig
previously approved these changes
Aug 22, 2019
bors bot
added a commit
that referenced
this pull request
Aug 22, 2019
42: Add equivalent of dbg! macro r=adamgreig a=nickray I think this would be quite useful. Thoughts? Maybe it would be better for `dbg!` to be in core with somehow switchable implementation (semihosting, vcom, etc.), but I don't know how to approach that. Added CHANGELOG also for the missing one for #39 Perhaps some more documentation is needed? Co-authored-by: Nicolas Stalder <[email protected]>
Build failed |
|
Looks like we'll need to edition-2018ify this crate first. |
|
Interesting, I see no compilation errors (also explicitly setting 2015 edition), and successfully link into a 2018 edition example. Does Travis have some sort of strict mode? Or maybe it's because I use 1.37. I assume the edition update should be a separate request, right? If I go at it, anything I need to consider besides making it compile? |
|
Hehe, adding stable thumbv8m testing fixed https://travis-ci.org/rust-embedded/cortex-m-semihosting/jobs/575372081 |
adamgreig
approved these changes
Aug 22, 2019
bors bot
added a commit
that referenced
this pull request
Aug 22, 2019
42: Add equivalent of dbg! macro r=adamgreig a=nickray I think this would be quite useful. Thoughts? Maybe it would be better for `dbg!` to be in core with somehow switchable implementation (semihosting, vcom, etc.), but I don't know how to approach that. Added CHANGELOG also for the missing one for #39 Perhaps some more documentation is needed? Co-authored-by: Nicolas Stalder <[email protected]>
|
We should probably mention edition2018 in the changelog but we can add that after. |
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this would be quite useful. Thoughts?
Maybe it would be better for
dbg!to be in core with somehow switchable implementation (semihosting, vcom, etc.), but I don't know how to approach that.Added CHANGELOG also for the missing one for #39
Perhaps some more documentation is needed?