Remove aligned, improve ITM code
#190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @therealprof (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
adamgreig
reviewed
Jan 15, 2020
bors bot
added a commit
that referenced
this pull request
Jan 15, 2020
190: Remove `aligned`, improve ITM code r=adamgreig a=jonas-schievink This does a handful of things: * Removes the dependency on `aligned` (and thus `as-slice` and the 2 versions of `generic-array`), instead providing our own simplified `Aligned` wrapper * Moves the innards of `write_aligned` to its own function, and calls that from `write_all` instead of transmuting `&[u8]` to `&Aligned<A4, [u8]>` (which is likely UB) * Fixes the doc example, which didn't compile anymore * Sinks the `#[allow]` attributes into the functions so they only cover the statements they need to Closes #184 Co-authored-by: Jonas Schievink <[email protected]>
|
Worth noting that this is a breaking change due to the different |
Build succeeded |
|
Nice! |
Closed
Sh3Rm4n
added a commit
to Sh3Rm4n/defmt
that referenced
this pull request
Mar 27, 2021
More specifically update cortex-m from 0.6.x to 0.7.x to reduce the dependency tree a little, see rust-embedded/cortex-m#190 Another interesting update is rtt-target (`0.2.x` -> `0.3.x`)
bors bot
added a commit
to knurling-rs/defmt
that referenced
this pull request
Mar 27, 2021
440: Update dependencies r=Urhengulas a=Sh3Rm4n More specifically update cortex-m from `0.6.x` to `0.7.x` to reduce the dependency tree a little, see rust-embedded/cortex-m#190 Another interesting update is rtt-target (`0.2.x` -> `0.3.x`) I've lazily used `cargo upgrade` to update the dependencies, which means patch release versions are also changed. I can revert these lines, if not desired :) Co-authored-by: Fabian Viöl <[email protected]>
adamgreig
pushed a commit
that referenced
this pull request
Jan 12, 2022
adamgreig
pushed a commit
that referenced
this pull request
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a handful of things:
aligned(and thusas-sliceand the 2 versions ofgeneric-array), instead providing our own simplifiedAlignedwrapperwrite_alignedto its own function, and calls that fromwrite_allinstead of transmuting&[u8]to&Aligned<A4, [u8]>(which is likely UB)#[allow]attributes into the functions so they only cover the statements they need toCloses #184