Prepare for release of new versions of cortex-m-semihosting and panic-semihosting #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
adamgreig
force-pushed
the
bump-semihosting
branch
from
d0d2153 to
81ab508
Compare
|
Build succeeded: |
|
Looks like this broke us, but I'm not entirely sure why? [xxx@xxx]:/tmp> git clone https://github.com/atsamd-rs/atsamd
Cloning into 'atsamd'...
remote: Enumerating objects: 74, done.
remote: Counting objects: 100% (74/74), done.
remote: Compressing objects: 100% (69/69), done.
remote: Total 133631 (delta 20), reused 28 (delta 4), pack-reused 133557
Receiving objects: 100% (133631/133631), 37.17 MiB | 28.83 MiB/s, done.
Resolving deltas: 100% (119612/119612), done.)
[xxx@xxx]:/tmp> cd atsamd/boards/metro_m
atsamd/boards/metro_m0
[xxx@xxx]:/tmp/atsamd/boards/metro_m0> cargo build --examples --features=unproven
Updating crates.io index
Compiling version_check v0.9.2
Compiling typenum v1.12.0
Compiling cortex-m v0.6.3
Compiling semver-parser v0.7.0
Compiling stable_deref_trait v1.2.0
Compiling proc-macro2 v1.0.24
Compiling vcell v0.1.2
Compiling unicode-xid v0.2.1
Compiling syn v1.0.44
Compiling bitfield v0.13.2
Compiling autocfg v1.0.1
Compiling cortex-m-rt v0.6.13
Compiling r0 v0.2.2
Compiling byteorder v1.3.4
Compiling nb v1.0.0
Compiling void v1.0.2
Compiling atsamd21g18a v0.7.0 (/tmp/atsamd/pac/atsamd21g18a)
Compiling hashbrown v0.9.1
Compiling proc-macro-hack v0.5.18
Compiling heapless v0.5.6
Compiling cortex-m-semihosting v0.4.0
Compiling cortex-m v0.5.10
Compiling metro_m0 v0.7.0 (/tmp/atsamd/boards/metro_m0)
Compiling rand_core v0.5.1
Compiling cortex-m-semihosting v0.3.5
Compiling aligned v0.2.0
Compiling rtic-core v0.3.0
Compiling jlink_rtt v0.1.0
Compiling panic-halt v0.2.0
Compiling volatile-register v0.2.0
Compiling nb v0.1.3
Compiling embedded-hal v0.2.4
Compiling semver v0.9.0
Compiling sx1509 v0.2.0
error: failed to run custom build command for `cortex-m-semihosting v0.4.0`
Caused by:
process didn't exit successfully: `/tmp/atsamd/boards/metro_m0/target/debug/build/cortex-m-semihosting-17563cdabaed1cca/build-script-build` (exit code: 101)
--- stderr
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }', /home/xxx/.cargo/registry/src/github.com-1ecc6299db9ec823/cortex-m-semihosting-0.4.0/build.rs:11:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
error: build failed |
|
We are seeing the same breakage in RTIC. |
adamgreig
pushed a commit
that referenced
this pull request
Jan 12, 2022
270: Add GitHub actions for CI r=adamgreig a=therealprof This changes CI from Travis CI to GHA which should not only vastly simplify the maintenance (by getting rid of pulling custom binaries from japaric's repository) but also speeds up the CI process and adds rustfmt as well as clippy checks for good measure. There's still room for optimisation but this has taken me long enough and plenty of sweat to get to this stage so my recommendation would be to merge it. Co-authored-by: Daniel Egger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the next step in #263 (review), this PR increases the version number for panic-semihosting and cortex-m-semihosting. For c-m-sh this is a breaking change to include #269.
Both projects seem to build just fine with cortex-m master, so I anticipate they should work fine with the to-be-released 0.7, hence increasing the acceptable cortex-m version range.
The CHANGELOG links are a bit troublesome, so I've added new tags to this repo
c-m-sh-v0.3.5andp-sh-v0.5.3which point to the merge commit, and I'll tag newc-m-sh-v0.4.0andp-sh-v0.5.4after this is merged.