Use latest mdbook version in CI #21
Conversation
austinglaser
requested review from
korken89,
ryankurte and
a team
as code owners
ci/install.sh
Outdated
| @@ -3,11 +3,10 @@ set -euxo pipefail | |||
| main() { | |||
| local tag=$(git ls-remote --tags --refs --exit-code https://github.com/rust-lang-nursery/mdbook \ | |||
| | cut -d/ -f3 \ | |||
| | grep -E '^v0.2.[0-9]+$' \ | |||
| | grep -E '^v[0-9]+$' \ | |||
There was a problem hiding this comment.
| | grep -E '^v[0-9]+$' \ | |
| | grep -E '^v0.[0-9]+.[0-9]+$' \ |
Should probably something like this instead?
There was a problem hiding this comment.
Happy to.
I was modeling this of the way the same script works in the embedonomicon book - should I change it there too?
There was a problem hiding this comment.
Do you think it would be better to pin it to the 0.3 series, so breaking changes have to be explicitly opted in?
There was a problem hiding this comment.
OK, I updated to your suggestion. I still think it's worth debating:
- Being more specific -- pinning to 0.3.x instead of 0.x.y
- Doing this same pinning on other
rust-embeddedbooks
(initial comment was from wrong account; sorry)
There was a problem hiding this comment.
And the first version had a stupid mistake. Updated again
There was a problem hiding this comment.
Originally it was free IIRC. We only pinned it to 0.2.1 due to a problem with later versions.
austinglaser
force-pushed
the
14-back-out-hardcoded-mdbook-version
branch
from
3017a81 to
2b8029f
Compare
This pins mdbook to the 0.x.y series for now.
austinglaser
force-pushed
the
14-back-out-hardcoded-mdbook-version
branch
from
2b8029f to
ba0f310
Compare
Fixes #14