Add nrf softdevice feature #55
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem as well as solution is documented in the [README][github] for embassy's nrf-softdevice crate. Please refer to the content there for details. In short; The application code is sharing the cpu with the vendor provided part of the firmware when using a nrf-softdevice. In order to keep radio communications and such working, the three interrupts the softdevice relies upon need not be blocked. Section for a draft pull-request description -------------------------------------------- In case there is disagreement on whether this is the correct crate for this or not, it might be worth at least being more explicit in the README about how this crate works by blocking all interrupts. Maybe one might wish to also extend the API documentation mentioning this? We're open for a conversation on how to best make this easy-to-overlook fact more visible. [github]: https://github.com/embassy-rs/nrf-softdevice#critical-sections
This relies on versions of embassy not yet published to crates.io, yet available from git. Deferring merge of the pull-request until there are proper releases might be reasonable.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @adamgreig (or someone else) soon. Please see the contribution instructions for more information. |
|
I think the right fix is to use This way this crate works with all kinds of CS implementations without having to add them here. See #56 |
|
#56 sure looks like the better solution. I'm closing this attempt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As has attempted to be described in the commit message, this is intended to address using this crate with Nordic Semiconductor's SoCs by adding a feature for acting slightly different with them. Since it adds a dependency on embassy, which is not yet distributed through crates.io, this is a draft pull request until the required crates have been stabilized.
There are likely improvements to be made to the details, but the main question should likely be; Could this addition stand a chance to get merged once the eco-system matures, or would doing this in some other way be considered a more
appropriate solution?