Skip to content

blocking::serial::* API #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
japaric opened this issue Feb 15, 2018 · 3 comments
Open

blocking::serial::* API #40

japaric opened this issue Feb 15, 2018 · 3 comments
Labels
needs-driver needs-impl unproven-api

Comments

@japaric
Copy link
Member

japaric commented Feb 15, 2018

These traits became available in release v0.1.2 behind the "unproven" Cargo feature.
@hannobraun
Copy link
Member

@japaric Did you add the needs-impl tag on purpose? It doesn't seem to apply, since the trait has a default implementation. Or do you want to see alternative implementations that bypass the default one before marking the API as proven?

@japaric
Copy link
Member Author

japaric commented Feb 16, 2018

It doesn't seem to apply, since the trait has a default implementation.

The default implementation is opt in. I still think it should be checked that the default implementation works on hardware.

Or do you want to see alternative implementations that bypass the default one before marking the API as proven?

That would be ideal but I don't think it should be a hard requirement.

@hannobraun
Copy link
Member

hannobraun commented Feb 19, 2018 •
edited
Loading

The default implementation is opt in. I still think it should be checked that the default implementation works on hardware.

Ah, that makes sense.

I'm using the default implementation in LPC82x HAL. As far as I can tell, everything works.

@caemor caemor mentioned this issue Nov 5, 2018
Closed
peckpeck pushed a commit to peckpeck/embedded-hal that referenced this issue Nov 10, 2022
@bors @LeSeulArtichaut
Merge rust-embedded#40
734f41e 
40: Add triagebot configuration r=posborne a=LeSeulArtichaut

This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

Co-authored-by: LeSeulArtichaut <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-driver needs-impl unproven-api
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hannobraun @japaric